Skip to content

Updates to CI and plotting#483

Merged
grantfirl merged 9 commits into
NCAR:mainfrom
dustinswales:feature/beef_up_plotting
May 30, 2024
Merged

Updates to CI and plotting#483
grantfirl merged 9 commits into
NCAR:mainfrom
dustinswales:feature/beef_up_plotting

Conversation

@dustinswales
Copy link
Copy Markdown
Member

This PR contains the following changes:

  • Update to SCM RT Baseline (Thanks @mkavulich)
  • More cleanup of the plotting script.
  • New comparison script for offline use (uses the same plotting script as in the RT CI)

@dustinswales
Copy link
Copy Markdown
Member Author

@grantfirl @mkavulich Can one of you review this?
(I know I need to revert the nml change, I did this just for testing)

Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for nml change.

@dustinswales
Copy link
Copy Markdown
Member Author

Looks good except for nml change.

Done.

Comment thread test/plot_scm_out.py
if file_rt is not None: plt.subplot(3,1,1)
plt.contourf(x1, y1, z1, 20, cmap='YlGnBu')
plt.ylim(1000,200)
plt.xlim(0,np.max(x1))
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grantfirl Sorry for the late addition.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No prob. Ready to merge?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do it.

@grantfirl grantfirl merged commit 567b8a3 into NCAR:main May 30, 2024
@grantfirl grantfirl mentioned this pull request May 31, 2024
@dustinswales dustinswales deleted the feature/beef_up_plotting branch July 1, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants